Trying to get property of non-object in entity_metadata_taxonomy_access()

Problem/Motivation

entity_metadata_taxonomy_access() sets NULL as the default argument value for $entity; however, the function doesn't actually handle situations where $entity = NULL.

E.g.

    case "delete":
      if ($entity_type == 'taxonomy_term') {
        return user_access("delete terms in $entity->vid", $account);
      }
      break;

The above code will result in the following notice if $entity = NULL:

Notice: Trying to get property of non-object in entity_metadata_taxonomy_access() (line 827 of /var/www/rovdev/sites/all/modules/entity/modules/callbacks.inc).

Proposed resolution

Check for $entity before trying to access its properties.

E.g.

    case "delete":
      if ($entity_type == 'taxonomy_term' && $entity) {
        return user_access("delete terms in $entity->vid", $account);
      }
      break;

Remaining tasks

• Submit patch
• Community review

User interface changes

None

API changes

Noe

Data model changes

None

Release notes snippet

None

Original report by sano

#2160355-20: Trying to get property of non-object in entity_metadata_user_access()