CommentFileSizeAuthor
#8 codingstandard-fix-2884293-8.patch6.25 KBindrapatil
#7 email_utm-codingstandard-2884293-3.patch6.83 KBsneha_chandole
#2 email_utm-codingstandard-2884293-2-D7.patch6.4 KBjayesh_makwana
email_utm.txt4.36 KBjayesh_makwana

Comments

jayesh_makwana created an issue. See original summary.

jayesh_makwana’s picture

jayesh_makwana commented
StatusFileSize
new email_utm-codingstandard-2884293-2-D7.patch6.4 KB

We create a patch for solving coding standard issues for this module. Please check and apply it.

mrded’s picture

mrded commented
Status: Active » Needs work

Thank you for your patch and raising this question.

However, from your patch, I can see another Coding Standard issues such following:

-      $enabled_variable_key = implode('_', array('email_utm_enabled', $module, $key));
+      $enabled_variable_key = implode('_', array(
+        'email_utm_enabled', $module, $key,
+      ),
+      );

It should be formatted like this:

-      $enabled_variable_key = implode('_', array('email_utm_enabled', $module, $key));
+      $enabled_variable_key = implode('_', array(
+        'email_utm_enabled', $module, $key,
+      ));
jayesh_makwana’s picture

jayesh_makwana commented

@mrded : Thank you for your suggestion. However, we are doing the coding standard check from the phpcs command.

Both solution is not providing coding standard issue.

And as per your suggestion, we will definitely follow this coding standard for decreasing number of lines of code.

mrded’s picture

mrded commented

Just curious, are you writing (using) a bot which does automatic coding standard check and creates issues?
I'm asking because no one is really using this module, and I was surprised why do you care about coding standards here :)

jayesh_makwana’s picture

jayesh_makwana commented

@mrded : Actually, we are trying to improve drupal's coding standard. Because of this everyday we are checking modules according to coding standards and provide them patch file for improvement of coding standard.

sneha_chandole’s picture

sneha_chandole commented
StatusFileSize
new email_utm-codingstandard-2884293-3.patch6.83 KB

Hello,

I have added patch for coding standard please refer if not solved yet.
Please check email_utm-codingstandard-2884293-3.patch file.

indrapatil’s picture

indrapatil commented
Assigned: jayesh_makwana » Unassigned
Status: Needs work » Needs review
StatusFileSize
new codingstandard-fix-2884293-8.patch6.25 KB

Hi,
I fixed the coding standard
please review.
Thanks

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

i will review this patch #8

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

patch working perfectly

jayesh.d’s picture

jayesh.d commented

Thanks patch 8 worked for me.