Going to #edit on whatever page enables Edit mode. Reloading the page should re-enter edit mode. That happens. But what fails to happen, is to indicate which fields are editable.

Comments

wim leers’s picture

Assigned: wim leers » Unassigned
Priority: Minor » Normal
Status: Active » Postponed
Issue tags: -sprint

This is a race condition: in D7 Edit, the Create.js PropertyEditor widgets are being loaded conditionally/JIT, and visiting a URL with the #edit fragment causes EditApp to be initialized before the metadata callback — along with the necessary PropertyEditor Widgets JS — has been loaded.

However, for a reason I don't understand yet, I can no longer reproduce this after clearing the browser cache.

wim leers’s picture

Issue tags: +sprint

This should be tracked down via git bisect.

wim leers’s picture

Status: Postponed » Active
wim leers’s picture

After clearing the browser cache, I stopped being able to reproduce this. I *think* the trick to start reproducing it again, is by:
1. enable edit mode
2. browse to a different URL
3. use the browser's back button
4. now consistently reproducible

So it somehow seems to become not reproducible due to strange browser cache interactions, causing the execution order to be different…?

wim leers’s picture

Version: 7.x-1.0-alpha6 » 7.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)
Issue tags: -sprint

Today I again can't reproduce this anymore. So weird.

If this pops up again, I'm just going to remove the Backbone route; it's no longer in D8 core right now either, and it's better to have them more in sync rather than spend extra time debugging this in D7.

wim leers’s picture

Title: Backbone route broken » Backbone route broken, but no consistent way to reproduce
Category: bug » task

Let's not let this increase Edit's bug count.

socialnicheguru’s picture

I have enabled edit and panels
I try to add "quick edit" block
the panel does not close when I click on the x in the upper right
the js error in firebug is the one described in the issue

wim leers’s picture

Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (won't fix)

This will be irrelevant soon, because I'm working on backporting the Drupal 8 implementation of in-place editing, which does not use Backbone Routes.