Problem/Motivation

Scanning this module with phpstan or Upgrade Status results in,

Direct injection of entity storage via $storage is not recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface and call getStorage() at the call-site instead.

Proposed resolution

Call getStorage() instead.

API changes

Theoretically, a third party that extended the classes could have to change their methods to match.

Issue fork eck-3625392

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !76

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Reviewed & tested by the community

Seems like that $eckEntityTypeStorage property isn't used in any ECK provided subclasses, so it's safe to remove.

dieterholvoet’s picture

dieterholvoet commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.