Closed (fixed)
Project:
Dynamic Persistent Menu
Version:
7.x-2.0-alpha2
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Nov 2011 at 22:25 UTC
Updated:
8 Apr 2012 at 16:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
alberto56 commentedThe existance of several dynamic menus in the system can cause #1360030: dpms.menus[settings_id] is undefined when more than one dynamic menu defined, prevents submenus from hiding after timeout, so right now for this module to work properly only one dynamic menu can be defined. Hence, fixing this is critical.
Comment #2
alberto56 commentedSame for editing dynamic menus directly on the block page.
Comment #3
alberto56 commentedThe enclosed patch, when applied to 7.x-2.x-dev (not 7.x-2.0-alpha2), creates a failing test demonstrating this problem. Fixing the problem should make this test pass.
Comment #4
alberto56 commentedI created a new git branch for this issue called 1356324. It contains the patch at #3 (which fails).
Comment #5
alberto56 commentedThere are still some glitches on the 1356324 branch, especially related to deleting dynamic persistent menus when they are already related to a block. All this is in the test: you can either check out branch 1356324 from git or apply the enclosed patch to the 7.x branch.
I will merge this into 7.x when all tests will pass.
Cheers,
Albert.
Comment #6
alberto56 commentedOK, fixed. All tests pass on the 7.x-2.x branch. See also related #1499524: Impossible to modify a dynamic menu directly in the block config page