I've discovered some problems when using the po box and/or the placeholders option (labels as placeholder).
When po box is enabled certain fields like house number are no longer shown, yet the when the placeholders option is enabled it still does its thing adding placeholders on those not existing house number fields. This leaves incomplete webform components in the element array, which causes problems obviously.

CommentFileSizeAuthor
#5 dvg_webform_components-fix_po_with_placeholders-2880269-5.patch10.64 KBralphvdhoudt
#4 dvg_webform_components-fix_po_with_placeholders-2880269-4.patch10.89 KBralphvdhoudt
#3 dvg_webform_components-fix_po_with_placeholders-2880269-3.patch10.6 KBpaulvandenburg
#2 dvg_webform_components-fix_po_with_placeholders-2880269-2.patch4.09 KBpaulvandenburg

Comments

pburg created an issue. See original summary.

paulvandenburg’s picture

paulvandenburg commented
Status: Active » Needs review
StatusFileSize
new dvg_webform_components-fix_po_with_placeholders-2880269-2.patch4.09 KB

This patch restructures the logic so placeholder stuff is only done on elements that actually exist.
Additionally I've added an empty array to element_info_property() which is returned if no element info was found for the element type, so the += operation doesn't fail.

paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new dvg_webform_components-fix_po_with_placeholders-2880269-3.patch10.6 KB

Tokens without replacement aren't cleared apparently for the default values. Picking that one up in this issue to not open an issue for every little thing.

Extracted the logic for calculating the default_value since those lines were already too long.
Added the 'clear' option to token_replace which is the only actual change in logic added on top of the above patch.

ralphvdhoudt’s picture

ralphvdhoudt commented
StatusFileSize
new dvg_webform_components-fix_po_with_placeholders-2880269-4.patch10.89 KB

Better patch

ralphvdhoudt’s picture

ralphvdhoudt commented
StatusFileSize
new dvg_webform_components-fix_po_with_placeholders-2880269-5.patch10.64 KB

Correct path

ralphvdhoudt’s picture

ralphvdhoudt commented
Status: Needs review » Fixed

Active for few months

  • ralphvdhoudt committed a712106 on 7.x-1.x 
    Issue #2880269 by paulvandenburg, ralphvdhoudt: PO box with placeholders...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.