The four _dslm_get_*base() functions in dslm.drush.inc have a logic bug in them that makes it so they exit too early.
All of them have code to check $_SERVER['HOME'] and the three other than _dslm_get_base() also specify a default, if nothing was found, but the logic flow in the block before those two checks exits prematurely, so the extra checks never happen.
I will be uploading patches momentarily.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | dslm-functions_exit_too_early-7x4x-2990649-4.patch | 3.23 KB | oadaeh |
| #4 | dslm-functions_exit_too_early-7x3x-2990649-4.patch | 3.23 KB | oadaeh |
Comments
Comment #2
oadaeh commentedEven though the changes are identical, I created a separate patch for both of the 7.x-3.x and 7.x-4.x branches to avoid fuzz when applying them.
(The four functions could be refactored to four stubs calling a fifth generic function to reduce much of the duplication, but I didn't want to get into that here.)
Comment #3
oadaeh commentedComment #4
oadaeh commentedIn re-reading through the logic, I realized there needed to be an additional check on $base when checking to replace the ~ dir, so here are patches that add that to the previous patches.