Replaced instances of drush_die with drush_set_error as per @msonnabaums comments in #33 of #1005480: Create a new project to develop Drush entity support. We may need t look at replacing various error types? currently I have put them all as general 'DRUSH_ERROR'.

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

This code change is committed to 7.x-5.x

Should we discuss the value DRUSH_ERROR?

damiankloip’s picture

damiankloip commented

Yes, sorry about committing to main branch. Oops. What shall we do with drush_error stuff?

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

No problem you committed this on main branch ... it's fixed now right :)

Do we have to introduce our own DRUSH_ENTITY_x codes? I'm not sure I get your point. For me this looks like a fixed.

Maybe some pointers to drush code would help?

damiankloip’s picture

damiankloip commented
Status: Needs review » Fixed

All codes have DRUSH_ENTITY_x that make sense to. They should be a bit more descriptive of the errors now.

Marking as fixed. Re open if you think these aren't right.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.