This is good and common practice for distinguishing contributed and custom themes. Making this change would make drush's handling of downloaded themes consistent with that for modules.

CommentFileSizeAuthor
#1 drush-891184.patch778 byteseli-t

Comments

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
StatusFileSize
new drush-891184.patch778 bytes
greg.1.anderson’s picture

greg.1.anderson commented

Code looks good.

soulston’s picture

soulston commented

Tested on Drush All-versions-3.0

This works fine for me - looks good.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Reviewed & tested by the community
moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Closed (won't fix)

I think this is overcomplicating. I see no reason why a site should keep around more than one or two non core themes. Use --destination in your drushrc if you want this.

psynaptic’s picture

psynaptic commented

I personally feel this is a bug in drush. It's about consistency more than anything. Would you reconsider?

toddgee’s picture

toddgee commented
Component: Code » PM (dl, en, up ...)

I'd also consider this to be a valid defect - for consistency. A user could always just not have a themes/contrib directory if they didn't want one. 'drush dl' doesn't *create* the 'contrib' directory if it's not already there.

It seems rather arbitrary that because one person doesn't see a reason to do something that things should act inconsistent.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Version: » 8.x-6.x-dev
Issue summary: View changes

Just for info the behaviour as proposed has now been implemented in drush elsewhere :)

(ignore the version change, d.o won't let me post the update without it).