Closed (fixed)
Project:
Drush
Component:
PM (dl, en, up ...)
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
8 Aug 2010 at 21:46 UTC
Updated:
16 Dec 2010 at 18:00 UTC
Jump to comment: Most recent file
I've only just spotted the new wildcard feature (eg "drush en views*" to enable views and all sub modules) which is a real timesaver. But there is one minor bug. The matching on the wildcard is a bit keen:
drush en date*
matches the date module and all sub-modules. But it also matches the "update" module. In regex terms, I suppose it's doing ".string" instead of "^string" when creating the list of modules on which to operate.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | drush-wildcard-fix.patch | 820 bytes | greg.1.anderson |
| #4 | drush-877302.patch | 779 bytes | jonhattan |
| #3 | drush-977048.patch | 24.42 KB | jonhattan |
Comments
Comment #1
moshe weitzman commentedHmmm. I can't get the wildcard to work for a string that matches the project name like views*. Thats because this test is FALSE:
if (($wildcard = rtrim($project, '*')) !== $project) {. I don't really get how views* works for anyone. Once the project name bug is fixed, I agree that the match should be changed to 'starts with'.Comment #2
jonhattanComment #3
jonhattan@moshe I don't see the problem in #1. Attached a fix for #0
Comment #4
jonhattanwoops! wrong patch
Comment #5
greg.1.anderson commented#4 works, but I suggest that the attached patch is easier to read. I don't really like the
=== 0, stylistically speaking.Comment #6
greg.1.anderson commentedActually, to avoid getting bogged down in bookkeeping over minor issues, I just committed this.