Hi Moshe,

while trying (without success) to run drush sql select nid from nodes just ran into dispatching code.

(This extra logging helps me in the future solving this sql problem.)

CommentFileSizeAuthor
drush-inc.patch1.26 KBclemens.tolboom

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

The patch is handy. My problem has nothing to do with drush but with my bash script :-/

moshe weitzman’s picture

moshe weitzman commented

The extra verbose stuff looks good.

You added too much indentation to one comment and you removed an array_reverse() without mentioning why.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Sorry for not mentioning. I pushed the array_reverse up out the if. As a DRY (don't repeat yourself)

What is the best way to tell such a change. Just in the patch?

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Needs review

Folks think this is worthwhile?

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

On second though this might be worth an --terse option ... if you are interested i will provide a --terse patch

moshe weitzman’s picture

moshe weitzman commented

I'm now not so keen on this. This really helps understand drush_dispatch which a command author does not need to understand. Only developers of drush itself really care about this. My .02 anyway. I'll leave this open for a bit.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Are you waiting for a new patch then?

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

-v option now takes a value of 1 or 2 or 3, etc. higher numbers mean more debug messages.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.