Closed (duplicate)
Project:
Drush
Version:
8.x-6.x-dev
Component:
Make
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Anonymous (not verified)
Created:
27 May 2013 at 10:39 UTC
Updated:
4 Mar 2018 at 14:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedHere is the patch against latest 8.x-6.x-dev (which also works perfectly for 7.x-5.x-dev) to resolve this feature request.
Please review and commit. Thank you!
Comment #2
Anonymous (not verified) commentedThere are some custom continuous integration scenarios where injection of project property into .info file during Git cloning is not necessary (because profile/module/theme is developed for single website and so it's not hosted at any update site and shouldn't be considered by Drupal update module). That's why I further improved my above patch to introduce --no-gitprojectinfo drush make option to skip injection of project info into .info files when cloning from Git.
Here is updated patch against latest 8.x-6.x-dev (which also works perfectly for 7.x-5.x-dev) to resolve this feature request.
Please review and commit. Thank you!
Comment #3
moshe weitzman commentedpm-download already has --gitinfofile option. Thats what make should set to FALSE in order to achieve this. I'm not too familiar with make in order to say exactly how that gets done.
Comment #4
Anonymous (not verified) commentedFor cloning from Git drush make uses its own implementation make_download_git(), so --gitinfofile option is irrelevant here (drush make implementation provides superior functionality than pm-download).
To process .info files drush make also uses its own implementation DrushMakeProject::processGitInfoFiles(), which in turn calls drush_pm_inject_info_file_metadata() to actually inject version info into .info files. That's why to implement --no-gitprojectinfo drush make option I also had to add corresponding check into drush_pm_inject_info_file_metadata().
Having said above, I still consider my patch appropriate and set status back to needs review.
Please review and commit. Thank you!
Comment #5
greg.1.anderson commentedThis issue was marked
closed (won't fix)because Drush has moved to Github.If this feature is still desired, you may copy it to our Github project. For best results, create a Pull Request that has been updated for the master branch. Post a link here to the PR, and please also change the status of this issue to
closed (duplicate).Please ask support questions on Drupal Answers.
Comment #6
bircherhttps://github.com/drush-ops/drush/issues/187
no pull request so far though.
Comment #7
greg.1.anderson commentedA pull request makes it more likely this will be noticed and acted on, that's all.
Changing status to 'duplicate' now that it has been migrated.