Closed (won't fix)
Project:
Drush
Version:
8.x-6.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Dec 2012 at 10:56 UTC
Updated:
11 Sep 2013 at 11:36 UTC
Jump to comment: Most recent file
Comments
Comment #1
gábor hojtsyIs it possible to look at this in patch form?
Comment #2
Johnny vd Laar commentedSure but the entire change is a single file that you can just drop in your .drush folder.
Comment #3
gábor hojtsyEmpty patchfile?
Comment #4
Johnny vd Laar commentedI'm sorry
Comment #5
gábor hojtsyThanks! A quick review:
Drupal never calls these "Drupal Locale"'s and especially not Drupal Locale PO files. I think the text could use some definite polish.
These two looks like entirely contradicting about the default location of the file?!
There is no "language group" in core. Eg. the API docs on the import function say "Text group to export PO file from (eg. 'default' for interface translations).". It is not about a group of languages, but a group of source strings per their role in the system.
This could use more polish as well. Although the functionality is implemented by locale module, this is not really something we call locale anywhere. It is "interface translations" for "languages". Not locale :) If you look through all the UI of the locale module, the word locale would AFAIR never even appear.
This will work in Drupal 6 and 7. I don't know about policy for Drupal 8 support, but this definitely does not work there.
"Imports a Drupal textgroups" again clearly needs some text polish.
Drupal uses $langcode to refer to the language code and $language to refer to an object (eg. one in the list of the $languages array). You use $language to refer to a langcode.
Comment #6
moshe weitzman commentedThanks for the patch and the review. I'm not sure if this is broadly useful enough for Drush core. We can discuss that. Meanwhile, it will need full unit tests in order to get into Drush core. See the other tests in the /tests folder. There is a README there. Also needs to work on D8/D7/D6.
Comment #7
moshe weitzman commentedAnd also needs a maintainer.
Comment #8
Johnny vd Laar commentedI must say that I haven't spent a lot of time on the wording of things so I will look into that.
But could something like this, if the texts would be better, be a possible addition to default drush? Or would it be better if I made it into a separate drush module?
Comment #9
Johnny vd Laar commentedOk thanks, well I can spent some more time on fixing the wording and look at d6 and d8 but I might need some help with the test coverage.
But I guess first you'll need to decide upon if it even can be included. Otherwise I will only fix the wording and make it into a separate module with only d7 support for now.
Comment #10
moshe weitzman commentedSorry, I won't give guarantees. I'd have to talk to the proposed maintainer about future features, his/her availability, etc.
Comment #11
Johnny vd Laar commentedokay and a maintainer, that would be someone who maintains a complete branch or just this one functionality?
Comment #12
moshe weitzman commentedA maintainer specifically for locale.drush.inc. jonhattan currently maintains pm, owen maintains runserver/quickdrupal, etc.
Comment #13
Johnny vd Laar commentedWell I am not really familiar with how drush works internally so perhaps someone more experienced is better for this.
Comment #14
steinmb commentedHi
Useful drush addon. Any chance for a re-roll with changes mention in #5?
Comment #15
Johnny vd Laar commentedFor my personal testing I've set up this sandbox: https://drupal.org/sandbox/johnnyvdlaar/1872144
The above string improvements are implemented there.
Comment #16
steinmb commentedThanx! I'll have a look :)
Comment #17
greg.1.anderson commentedThis issue was marked
closed (won't fix)because Drush has moved to Github.If this feature is still desired, you may copy it to our Github project. For best results, create a Pull Request that has been updated for the master branch. Post a link here to the PR, and please also change the status of this issue to
closed (duplicate).Please ask support questions on Drupal Answers.