Problem/Motivation

Inconsistency in how the site handles links

Proposed resolution

All internal links open within the same window, and all external links open a new window.

Remaining tasks

Each page on the existing site needs to be reviewed to determine if internal and external links are targeted correctly.

User interface changes

Consider using a module to automatically convert external links to include target=_blank

Original report by [squares]

Hey all, I fixed the ones I was able to, but it seems that there's a bit of inconsistency in how the site handles links. I'd like to propose that

The permissions are such that I'm able to edit some nodes, but not others. I'm happy to help with all of them if you'd like... just let me know.

Comments

bryanhirsch’s picture

Thanks for helping out with the Learn Drupal distro.

Please reformat this issue according to the issue template here.

If you don't have enough information to propose a resolution or write up remaining tasks, please write a "remaining task" suggesting a next step that will move the issue closer to having a known resolution and/or clear follow-up tasks.

Examples:
http://drupal.org/node/1495642
http://drupal.org/node/1494982
http://drupal.org/node/1495664

squares’s picture

Alright... I took a stab at it. Hopefully that's better?

BrockBoland’s picture

External Links should do the trick.

BrockBoland’s picture

Project: Learn » Drupal Ladder
Version: 7.x-1.0-alpha3 » 7.x-1.x-dev
Component: User interface » Code
makangus’s picture

Status: Active » Needs review
StatusFileSize
new4.79 KB

Attached a patch, does it make sense at all?

BrockBoland’s picture

Status: Needs review » Fixed

Tested and committed. Thanks makangus! I also made extlink a dependency of learn_default_site_settings

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Reformatted to meet the issue summary standards