I would like to report a small bug which my users are complaining about.
Using nodejs polling there is not notification sound when receiving messages

thanks for this great module

CommentFileSizeAuthor
#1 nodejs_sound.diff551 bytesadixon

Comments

adixon’s picture

StatusFileSize
new551 bytes

True, I just found the bug in this file: drupalchat_nodejs/drupalchat_nodejs.js

Patch attached.

alexandrezia’s picture

You nailed it, thanks!
Working here

alexandrezia’s picture

Status: Active » Needs review
darklrd’s picture

Status: Needs review » Fixed

Thank you for the patch. I have committed it to the dev branch - http://drupalcode.org/project/drupalchat.git/commit/b1d75a0.

  • Commit b1d75a0 on 7.x-1.x authored by adixon, committed by darklrd:
    Issue #2254333: No notification sound when using nodejs polling
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.