Use machine name for taxonomy permissions [#986168]

After seeing discussion about removing vid eventually from vocabularies and just using the machine name, it seems to make sense to use machine name for taxonomy permissions ( edit terms in vid, delete terms in vid ) instead of vid. This also makes sure that permissions for taxonomy are guaranteed to be exportable.

Comment	File	Size	Author
#1	taxonomy_perms_986168.patch	1.67 KB	bblake

Comments

Comment #1

bblake commented 1 December 2010 at 13:50

Status	File	Size
new	taxonomy_perms_986168.patch	1.67 KB

Patch included

Comment #2

febbraro commented 1 December 2010 at 18:45

Comment #3

joelcollinsdc commented 27 January 2011 at 17:33

Comment #4

mr.baileys

Dutch

🇧🇪 (Ghent)

commented 3 June 2011 at 12:53

Version:	7.0-beta3	» 8.x-dev
Status:	Active	» Needs work

Using the machine name instead of vid in the permission name certainly makes sense from a DX perspective. A couple of issues with the current patch though:

Contrary to vids, machine names can actually change during the life-time of a vocabulary. You'll have to come up with a mechanism to determine when the machine name is being altered, and update the permissions accordingly
Machine names can be up to 255 chars, while permissions are limited to 128 chars, which means the above patch breaks when using ridiculously long machine names for a vocabulary

Reviewing your patch also made me look for the original patch that introduced these permissions. Take a look at #340652: Edit/delete terms permission per vocabulary, it has in-depth information on vid versus machine name. If you go through with this patch, make sure you address the issues raised in that thread.