fix hook_module_disabled() comment and add tests

I think the test does not trigger the error. Here is patch that only changes the test case and it does not fail on my machine. Let's see what the bot says.

Subscribe.

Tried it, but doesn't seem to work.

Setup:

function module1_modules_disabled($modules) {
  dsm('hook_modules_disabled()');
  module_invoke_all('foobarbaz');
}

function module2_foobarbaz() {
  dsm('hook_foobarbaz()');
}

When disabling module2, only the "hook_modules_disabled()" message is displayed.

As fago said: you cannot use module_invoke_all() as it uses module_implements() which does not work at this point (this is a separate issue).

Otherwise the test now correctly triggers the error, RTBC for me.

[Sorry, duplicate comment — had some weird display bug here just now.]

Then what exactly does this patch fix?

Also, as mentioned in #978832: enable modules to apply configuration (exportable entities), your own code using this doesn't work for me, so there has to be a bug somewhere.

Sorry, my bad — made a stupid mistake when testing.

Patch seems to be RTBC to me, too.

Why do we want to move the code, versus updating the code comment.

Based on the name, I'd expect hook_modules_disabled() to be called after the modules have been disabled.

If the hook is going to be called before the modules are disabled, I'd expect it to be called hook_module_disable(), i.e. no trailing 'd'.