In Drupal 6 and 7, aggregator module ignores the Atom entry <id> element. It should instead treat Atom entry <id> as equivalent to the RSS item <guid> element.

CommentFileSizeAuthor
#10 aggregator-atom-id-971812.patch733 bytestwistor
#2 atom-id.d7.patch1.7 KBmfb
#1 atom-id.d7.patch862 bytesmfb
atom-id.d6.patch918 bytesmfb

Comments

mfb’s picture

mfb
they or he
commented
Version: 6.x-dev » 7.x-dev
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new atom-id.d7.patch862 bytes
mfb’s picture

mfb
they or he
commented
Issue tags: -Needs tests
StatusFileSize
new atom-id.d7.patch1.7 KB

add a test which fails without this patch.

theorichel’s picture

theorichel commented

subscribe

verta’s picture

verta commented

subscribe

theorichel’s picture

theorichel commented

I have tried the D6 version and I am a happy man, it works! Thanks very much!

twistor’s picture

twistor commented
Status: Needs review » Reviewed & tested by the community

Tested with http://utcc.utoronto.ca/~cks/space/blog/?atom. Works!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

mfb’s picture

mfb
they or he
commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Needs review

The d6 version of the patch is in the initial post.

mfb’s picture

mfb
they or he
commented

Ping. Looks like this patch didn't make it into Drupal 6.22 :(

twistor’s picture

twistor commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new aggregator-atom-id-971812.patch733 bytes

Re-rolled initial patch to apply without p0.

Other than that, it's golden.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed, pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.