Can anyone confirm this? I tried to install third party themes for DP7 and may found some bugs def. depending on DP7, because it is repeatable with any other DP7 theme, like robon, f.e. It tried with the Fuse Basic theme, and it seems the theme tab of the theme appeared only once and under certain circumstances in the tabs bar of block administration and disappears again for no reason and without any warnings from the tabs bar in the settings/structure/blocks administration window. I set the theme as default theme and wanted to change block settings, but after pressing "save", the Fuse theme tab disappeared and the setting-page shows the drupal default theme tab activated for editing. Only the demonstrate blocks link on top still uses the choosen theme name in the link text. (running Seven default admin theme)

Another little bug I found is, that the option (I really like!), to press active theme as default while installation from url isn't working. The default theme from before keeps being the default active theme.

Thanks for reading.
Best regards ...

CommentFileSizeAuthor
#10 poor_block_menu.patch1.11 KBcatch

Comments

EvanDonovan’s picture

EvanDonovan commented
Version: 7.0-beta2 » 7.x-dev
Assigned: BrittaL » EvanDonovan

Please do not assign issues to yourself, unless you are going to look at them yourself.

I am going to spend the next 30 minutes seeing if I can reproduce this issue, but I am not entirely sure what the issue actually is.

If you could clarify it would be helpful. Also, try it again with the latest dev version.

Finally, the bug you mentioned in your last paragraph sounds like a separate (non-critical) issue. Please open a separate issue report for that, and mark it as "normal" (read the issue status descriptions).

EvanDonovan’s picture

EvanDonovan commented

Note to self: "Set as default" did not work when I installed a third-party theme from a URL. Open that as a separate normal-level issue (if it doesn't already exist) once I get done trying to reproduce this.

BrittaL’s picture

BrittaL commented

I will try. I hope I understood correctly. Sorry, I am not an english native. That's why I didn't know exactly what it is about the assigned selection box. I think now I understood. Thanks for trying to clearify.

To make things clearer about the first issue: go to administration/structure/blocks and watch the behaviour of the tabs on top right. try to choose a third-party theme to change blocks in regions and try to save it. You will see that the third-party theme tab on top right will disappear, while the link "demonstrate block regions (third-part theme name) stays. And changes seem not to admit. Sorry for my bad english.

Can somebody please change teh first post title to the correct path "administration/structure/blocks"? thanks

hope I could help with this ...
thanks for reading.

best regards

EvanDonovan’s picture

EvanDonovan commented

The main bug (missing block configuration tab) is confirmed. Digging in further...

(I'll write a clarification of the issue shortly.)

BrittaL’s picture

BrittaL commented

is there any contiguity to this -> http://drupal.org/node/717712 ?

EvanDonovan’s picture

EvanDonovan commented
Title: third party themes behavior in settings/structure/blocks administration » Contributed themes block configuration tab misnamed/does not show when multiple themes enabled
Assigned: EvanDonovan » Unassigned

Ok, I've tested this with several different contributed themes now (on checkout of current 7.x dev), and can confirm the problem.

Basically, if you enable a contributed theme, but leave Bartik enabled, then the tab at the top of admin/structure/block will still say Bartik even though the "Demonstrate block regions" text will mention the correct theme.

Sometimes the tab for the contributed theme doesn't seem to show up at all when you go to admin/structure/block, but that is not consistent.

You have to disable Bartik in order to get the tab for the block settings to show up correctly for the contributed theme.

Steps to reproduce:

1) Install a theme (either using file system method, or D7 install from URL). (Note that if you click "Set as default" when installing from URL, the theme is enabled, but not set as default.)
2) Set the theme to be default in the Appearance settings.
3) Go to blocks config. It says "Bartik" on the active tab. Fusebasic won't show on a tab.
4) Go back to blocks config again. Bartik, Fusebasic, and Seven will show, but Bartik will still look like it is active.
5) To fix, you must disable Bartik.

I have tested this using the authorize.php method new to D7, as well as just installing themes from the file system. I didn't test the file system method from an untouched D7 install, though, so that would be good for someone else to test. Also, it would be good for someone to test without having the Overlay ever enabled, since my first test was with install from URL while in the Overlay.

Leaving this as critical, though it might get downgraded to major.

carlos8f’s picture

carlos8f commented

Subscribing

BrittaL’s picture

BrittaL commented

For me it happend with an untouched install of DP7 Beta 2 (thread starter). But it disappeared after flushing all caches. if it comes back I will report ...

EvanDonovan’s picture

EvanDonovan commented

I was using 7.x-dev, and I did not flush caches, but I had saved the Appearance, which should have rebuilt the theme registry, which should have been sufficient.

Britta, can you test it on 7.x-dev (either the tarball or CVS), starting out with no third-party themes installed, and then installing a different one besides Fusebasic?

I had experienced the problem with several themes, but I started off by installing Fusebasic, so it might have already gotten off.

catch’s picture

catch
he/him
Primary language English
commented
Component: theme system » system.module
Priority: Critical » Normal
Status: Active » Needs review
StatusFileSize
new poor_block_menu.patch1.11 KB

This is just a normal bug, and it'll get corrected as soon as there's a menu_rebuild().

Downgrading but posting a patch.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

subscribing

BrittaL’s picture

BrittaL commented

thanks for info, catch ...

@Evan: can confirm your procedure. same here.

BrittaL’s picture

BrittaL commented

@Evan: I think, the last pointing in my starting post was a misunderstanding of mine, what the link means to do. It is linking to the page where you can set it as default then, it's not setting it as default by only clicking it, what would be also a great idea to have at this particular situation there by the way. :-)

EvanDonovan’s picture

EvanDonovan commented

@Britta: I think that your last point might have been fixed in the last few weeks. There have been a lot of changes to update manager.

@catch: Will the double menu rebuild cause significant performance degradation? Do they happen on the same page request?

Jeff Burnz’s picture

Jeff Burnz commented

#10: poor_block_menu.patch queued for re-testing.

joachim’s picture

joachim commented

I filed this as #698406: block_menu() broken: depends on theme at time of menu cache rebuild, which was marked as a duplicate of #690544: Blocks admin (admin/structure/block) requires menu_rebuild() to display settings for current theme.

EvanDonovan’s picture

EvanDonovan commented
Status: Needs review » Closed (duplicate)

Flagging this as duplicate then, since that patch has a test.