Since full term object loading has been added to the taxonomy_get_tree function (#870528: taxonomy_get_parents(), taxonomy_get_children(), and taxonomy_get_tree() do not return a full term objects), the multi-parents do not work any more.

This can be easily reproduced by creating a simple hierarchical vocabulary with a term that has two parents. When you look at the term overview page, this multi parent will only be listed once.
For this I added a simple test case, which ensures that the term overview page (which uses taxonomy_get_tree) correctly lists multi-parent terms.

Further, we should consider, that loading the full terms slows down this function.

CommentFileSizeAuthor
multi-parents-test-case.patch901 bytesmh86

Comments

chx’s picture

chx commented
Priority: Normal » Major
Status: Needs work » Needs review

First let's see what the bot says.

Status: Needs review » Needs work

The last submitted patch, multi-parents-test-case.patch, failed testing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

I think this is intended behavior, as the term overview page clearly says:
"Tags contains terms with multiple parents. Drag and drop of terms with multiple parents is not supported, but you can re-enable drag-and-drop support by editing each term to include only a single parent."

This doesn't mean that multi parents don't work at all - just drag and drop is not supported.

Am I missing something?