The node edit test currently fails with:

Node edit 91 passes, 2 fails, and 0 exceptions

This is because it does a:

$this->assertIdentical($node->uid, $this->admin_user->uid, 'Node authored by admin user.');

$node comes from a node_load(), while $this->admin_user->uid comes from a db_insert().

To be 100% safe, SQLite should stringify all fetches (that will put it on par with PostgreSQL).

CommentFileSizeAuthor
#1 851590-sqlite-stringify-fetches.patch1.22 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 851590-sqlite-stringify-fetches.patch1.22 KB

Fairly trivial patch. There was a needless cast to in DatabaseConnection_sqlite::nextId() and we add PDO::ATTR_STRINGIFY_FETCHES => TRUE for consistency with PostgreSQL.

damien tournoud’s picture

damien tournoud commented
Priority: Normal » Critical

This is a test failure on SQLite. Critical as a consequence.

Stevel’s picture

Stevel commented
Status: Needs review » Reviewed & tested by the community

Looking good, and "93 passes, 0 fails, 0 exceptions" after applying this patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Tested, now test passed

Crell’s picture

Crell commented

I may have to reference this patch on the PHP-DEV list if they are still insistent on having strict typing in PHP 5.next. Yeesh. (I'm +1 here.)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.