Bartik: create hover state for collapse/uncollapse buttons in fieldset headers

I concede that my opinion here is probably influenced greatly by already being accustomed to clicking on the text to collapse a fieldset, but I dont think that this is an uncommon user experience. I think that the proximity of the indicative to the legend text helps and that even Drupal newbies will be quick to understand...

That said, I think joachim's concern is not entirely unwarranted ... things could probably be made clearer but I'm not certain of the best way to do that and I'm not convinced its necessary.

Other thoughts?

Hmmmm, well now that Bartik is in core, I'm moving over as few issues as possible. I think this is more of a personal taste kind of a thing than an actual bug report. So at this point, I'm going to set this to won't fix and not move it to the Drupal project.

I wouldnt object to making the legend underline on mouseover...

Didn't try it myself, but joachim's observation and explanation makes sense to me.

Due to D7's new and vastly improved markup for collapsible fieldsets, this should be easily changeable.

Yeah, I take back my 'won't fix'. Let's find a solution.

this certainly helps...

screenshots?

on hover....

+++ themes/bartik/css/style.css	11 Jul 2010 19:45:34 -0000
@@ -982,6 +982,9 @@ fieldset legend {
+fieldset legend:hover {

1) Only .collapsible fieldsets can be clicked.

2) Only the clickable fieldset title can be clicked.

i.e.: fieldset.collapsible a.fieldset-title

On a related note, all fieldsets look entirely different for me than in #10:

sun: good point on the selector ...

What browser/os are you using for that screenshot?

Firefox 3.5 on Windows XP/2003

...looks like work, eh? ;)

I like the screenshot in #10. Let's do that.

I like #10 too, seems to be an issue with Firefox 3.5 rather then 3.6.6 as I can't replicate sun's issue on my Windows XP, Firefox 3.6.6

Let's keep this issue about one thing. The bugs reported in comment #11 need to go into a separate issue. (Stop killing the kittens!)

Meanwhile, the original issue about about making it more obvious where to click to open the fieldset. The patch in #8 does a good job by making the text underlined when you hover on it. Let's review that and get this into Bartik.

#8: fieldset-hover.patch queued for re-testing.

I'd highly recommend to fix all fieldset styling issues at once. Using markup_test module from my sandbox, you can see, analyze, and fix all possible fieldset states on a single page without having to click anywhere.

We won't get anywhere soon, if all of the many details of collapsible, collapsed, and not collapsible fieldsets are tackled in separate issues. Especially, since we need cross-platform/browser testing for every single issue. There's a lot to take into account, and it's far too easy to forget about or not recognize another possible fieldset state.

Therefore, I can only recommend to broaden the topic and scope to "Bartik fieldsets", in all possible states, which are all to be tested, and fixed, in one shot.

At the very least, the actual CSS code issues mentioned in #11 remain.

Created meta issue to track fieldset issues, agree with sun here, maybe we can start closing some of the issues down (consolidate) and write one patch to rule them all - many are closely related by the looks.

#893460: Fix Bartiks Fieldsets (meta)

This issue is fixed in HEAD (Bartik's fieldset legends are underlined on hover).

EDIT: fixed by commit #417572