this small patch fixes a wrong permission check in the aggrgator of drupal 4.4.x.
Due to that wrong check onlu admin (uid1) could see the blog this icons. all others woiuld fail to see them.

This patch fizes that.

CommentFileSizeAuthor
#5 maintain_to_editown.patch7.43 KBTDobes
#2 repair_aggrgator_blog_permission_0.patch861 bytesBèr Kessels
repair_aggrgator_blog_permission.patch883 bytesBèr Kessels

Comments

dries’s picture

dries commented

Committed to DRUPAL-4-4. (IIRC blog permissions are broken in HEAD as well.)

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new repair_aggrgator_blog_permission_0.patch861 bytes

this patch is for HEAD.

dries’s picture

dries commented

grep -r 'maintain personal blog' * | wc -l
That patch doesn't update all instances in HEAD.

dries’s picture

dries commented
TDobes’s picture

TDobes commented
Title: aggregator "blog it" links use wrong permission » Rename "maintain personal foo" permissions to "edit own foo"
Component: aggregator.module » base system
Assigned: Bèr Kessels » TDobes
StatusFileSize
new maintain_to_editown.patch7.43 KB

The attached patch changes CVS HEAD permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.

Changes are as follows:
"maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
"maintain personal pages" -> "edit own pages" (page.module)
"maintain personal stories" -> "edit own stories (story.module)

dries’s picture

dries commented

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented