The patch in #86 for #679036: Upgrade to jQuery UI 1.8 doesn't include all the dependencies for dialog listed in /misc/ui/jquery.ui.dialog.min.js

This means that some things, like the position option, do not work because they need the dependencies. The attached patch adds these dependencies.

CommentFileSizeAuthor
#4 jquery-dialog.patch720 bytesjames.elliott
#2 jquery-dialog.patch525 bytesjames.elliott
jquery-dialog.patch525 bytesjames.elliott

Comments

Status: Needs review » Needs work

The last submitted patch, jquery-dialog.patch, failed testing.

james.elliott’s picture

james.elliott commented
Status: Needs work » Needs review
StatusFileSize
new jquery-dialog.patch525 bytes

Re-rolled the patch after a fresh update to HEAD

Status: Needs review » Needs work

The last submitted patch, jquery-dialog.patch, failed testing.

james.elliott’s picture

james.elliott commented
StatusFileSize
new jquery-dialog.patch720 bytes

For whatever reason my CVS client was creating the patch from the modules directory and not root. New patch that should pass testing attached.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review

If this gets the bot's green light, I'd consider it RTBC!

james.elliott’s picture

james.elliott commented
Status: Needs review » Reviewed & tested by the community

The patch is green

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Looks good. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.