* Notice: Undefined property: stdClass::$title in node_form_submit() (line 389 of /var/www/drupal7/modules/node/node.pages.inc).
* Notice: Undefined property: stdClass::$title in node_form_submit() (line 390 of /var/www/drupal7/modules/node/node.pages.inc).

This is shown when saving existing node, when content type was created which has_title = FALSE.
We should have test for has_title = FALSE.

Can someone check messages and fix them if needed.

CommentFileSizeAuthor
#9 title3.patch4.27 KBkcybulski
#7 title2.patch3.74 KBkcybulski
#4 title.patch2.57 KBkcybulski
#1 node_pages_inc.patch1.91 KBkcybulski

Comments

kcybulski’s picture

kcybulski commented
Status: Active » Needs review
StatusFileSize
new node_pages_inc.patch1.91 KB

Patch

kcybulski’s picture

kcybulski commented
Status: Needs review » Needs work

W really need tests.

On node preview.

* Notice: Undefined property: stdClass::$title in node_build_content() (line 1265 of /var/www/drupal7/modules/node/node.module).
* Notice: Undefined property: stdClass::$title in template_preprocess_node() (line 1337 of /var/www/drupal7/modules/node/node.module).
* Notice: Undefined property: stdClass::$title in template_preprocess_node() (line 1337 of /var/www/drupal7/modules/node/node.module).

Why we are running template_preprocess_node() two times ?

damien tournoud’s picture

damien tournoud commented
Priority: Critical » Normal

Doesn't qualify as critical, but we indeed need to fix this.

kcybulski’s picture

kcybulski commented
StatusFileSize
new title.patch2.57 KB

# Notice: Undefined index: title in rdf_preprocess_node() (line 482 of /var/www/drupal7/modules/rdf/rdf.module).
# Notice: Undefined index: title in rdf_preprocess_node() (line 482 of /var/www/drupal7/modules/rdf/rdf.module).

Notice: Undefined property: stdClass::$title in menu_node_save() (line 513 of /var/www/drupal7/modules/menu/menu.module).

kcybulski’s picture

kcybulski commented
Status: Needs work » Needs review

needs review

Status: Needs review » Needs work

The last submitted patch, title.patch, failed testing.

kcybulski’s picture

kcybulski commented
Status: Needs work » Needs review
StatusFileSize
new title2.patch3.74 KB

again

Status: Needs review » Needs work

The last submitted patch, title2.patch, failed testing.

kcybulski’s picture

kcybulski commented
Status: Needs work » Needs review
StatusFileSize
new title3.patch4.27 KB
retester2010’s picture

retester2010 commented

#9: title3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, title3.patch, failed testing.

Vc Developer’s picture

Vc Developer commented
Version: 7.x-dev » 7.0

Any news on getting this fixed? I get a something of the same:

Notice: Undefined property: stdClass::$title in template_preprocess_node() (line 1450 of /var/www/drupal/7.0/drupal-7.0/modules/node/node.module).
Notice: Undefined property: stdClass::$title in node_page_title() (line 2076 of /var/www/drupal/7.0/drupal-7.0/modules/node/node.module).

When using "Quick Tabs for D7" with the "Hide the title of this node" enabled. Works fine otherwise!

eleleka’s picture

eleleka commented

The same trouble

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ /var/www/drupal7/modules/menu/menu.module	2010-05-17 22:23:03.000000000 +0200
@@ -510,7 +510,7 @@ function menu_node_save($node) {
-        $link['options']['attributes']['title'] = trim($node->title);
+        $link['options']['attributes']['title'] = trim(isset($node->title));

That line makes no sense. You can't trim the result of isset(). Also, the menu link needs to have a title. So not sure what should happen in case it doesnt' exist.

And not sure about that patch anyway. Shouldn't $node->title be set to an empty string instead by whatever module is hiding it?

Or can someone confirm that this happens with *only* core, without any modules that hide the title?

Powered by Dreditor.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Closed (won't fix)

No response from OP.