The filter_update_7005() update function previously contained updates for all (or at least most) core modules to remove instances of '0' in text format columns in database tables.
It made sense to do it there in that one central location for code readability, but in the interim, all but one of these cases had to be moved out of filter module for other reasons anyway, leaving only the block module update. Since that's the only one, it makes more sense to move it to the block module, for better code separation, and to allow us to remove unnecessary dependencies between core modules.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | decouple-filter-block-updates.patch | 6.21 KB | David_Rothstein |
Comments
Comment #1
David_Rothstein commentedHere's the patch. Actually this is "needs work" pending #717834: The dependencies declared in core's hook_update_dependencies() implementations aren't actually correct, since currently this patch seems to break the D6->D7 upgrade path due to the tangled mess of dependencies that we currently have. For example, you can see from the code here that the hook_update_dependencies() call which this removes, which had the effect of making the block dependency work correctly, actually declares a dependency on the taxonomy module instead?!
Comment #2
sunThis patch looks good to me - not sure why we have to postpone it on that meta issue...?
Comment #4
sun#1: decouple-filter-block-updates.patch queued for re-testing.
Comment #6
sun#1: decouple-filter-block-updates.patch queued for re-testing.
Comment #8
David_Rothstein commentedThis is way outdated, and got fixed somewhere else along the way. The block updates are here now, all in the Block module: http://api.drupal.org/api/drupal/modules--block--block.install/function/...