aggregator categorize feature is broken

This is the result of "The signature of the callback from drupal_get_form() changed to add $form"

The aggregator module uses aggregegator_page_category() and aggregator_page_source() both as normal callbacks as well as through a drupal_get_form callback. This leads to a strange function signature:

function aggregator_page_category($arg1, $arg2 = NULL) {
  // If there are two arguments then we are called as a form, $arg1 is
  // $form_state and $arg2 is $category. Otherwise, $arg1 is $category.
  $category = is_array($arg2) ? $arg2 : $arg1;

The fact that $form was added to the drupal_get_form callback signature causes this to fail.

I'd opt to split the function into a regular callback and a callback for drupal_get_form. This fixes the issue, and is more developer friendly.

Marked #725640: Module fails to load RSS Feed with errors as a duplicate. Improved the doxygen comments in the previous patch some more.

#3: aggregator.patch queued for re-testing.

Patch looks sane enough. Could we add a quick test - just visiting the path ought to be enough to trigger it no?

We could add tests (you are right, a simple page visit will trigger the notices), but I'd prefer to have this handled by #276486: Tests needed: aggregator.admin.inc and #276499: Tests needed: aggregator.pages.inc to prevent scattered bits and pieces of tests. On the other hand, those two issues haven't seen much movement lately.

I've actually been closing out those "tests needed" issues because they're usually so stale that there's no useful summary of what's actually missing or not - since we moved to adding tests when and if rather than just trying to get coverage up overall, but this could probably go in as a quick fix as well.

Here's the test.

edit: this was supposed to be just the test by itself, but other patches got in with it, however the 8 exceptions are the ones we wanted to see. Following post is the patch + the test together.

And the patch + test combined.

Thanks catch! Test looks good to me, and confirmed that the test correctly catches the bug without the rest of the patch applied. Now we just need someone else to review & RTBC...

I reviewed #3, mr.baileys reviewed #16. Test bot reviewed both, I think that's a quorum.

Good fix. Committed to CVS HEAD. Thanks.