I implemented hook_node_update() and wanted to display a message for debugging purposes, but it never shows up when updating the node with the overlay module activated. I assume the message is shown in the overlay right before it closes.

Is this intended usability behavior or is this a bug?

Workaround: Deactivate the overlay module and the messages are shown as expected.

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Priority: Normal » Critical

Escalating to critical as the overlay also eats up error messages that may be inserted for example during hook_node_update().

coderintherye’s picture

coderintherye commented
Title: Overlay suppresses drupal_set_meassage() after node upate » Overlay suppresses drupal_set_message() after node upate

Being detail oriented, and fixing the spelling error in title.

cwgordon7’s picture

cwgordon7 commented
Assigned: Unassigned » cwgordon7
EvanDonovan’s picture

EvanDonovan commented

I think there is an issue that David_Rothstein created that might resolve this, which is RTBC. Not sure what the # of it is now...

catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Normal

Not critical, just a normal bug.

casey’s picture

casey commented

#658720: Clean up overlay_close_dialog() and related code

cwgordon7’s picture

cwgordon7 commented

#662856: Submitting a form that closes the overlay causes the form to flash on the screen again before it closes should fix the bulk of the problem, but this issue will require an additional patch to remove a little bit of the stupidity from overlay.module.

EvanDonovan’s picture

EvanDonovan commented
Title: Overlay suppresses drupal_set_message() after node upate » Overlay suppresses drupal_set_message() after node update

#662856: Submitting a form that closes the overlay causes the form to flash on the screen again before it closes was committed - what's next?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs work

Issue is not fixed, setting back to Needs work.

ksenzee’s picture

ksenzee
she/her
commented
Status: Needs work » Active

It's not needs work until there's a patch. :)

David_Rothstein’s picture

David_Rothstein commented

Try out the patch at #658720-34: Clean up overlay_close_dialog() and related code (this is the same issue @casey linked to above). With #662856: Submitting a form that closes the overlay causes the form to flash on the screen again before it closes already committed, I think that's the only other one we need to solve this issue - at least, that seemed to work for me.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Fixed

Fixed by #658720: Clean up overlay_close_dialog() and related code

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.