patchy :)

With chx's help we found a bug when trying to field_update_* while field_storage_default is set to mongodb field storage.

CommentFileSizeAuthor
#3 file.crud_.inc_.patch682 byteslitwol
#1 field_storage_module.patch682 byteslitwol
field_storage_module.wtf_.patch682 byteslitwol

Comments

litwol’s picture

litwol commented
StatusFileSize
new field_storage_module.patch682 bytes
litwol’s picture

litwol commented
Issue tags: +Release blocker

Sorry for so many updated.. getting familiarized with submitting core patches.

litwol’s picture

litwol commented
StatusFileSize
new file.crud_.inc_.patch682 bytes

Not sure why the patch was ignored.

litwol’s picture

litwol commented
Status: Active » Needs review

Hopefully that solves the mystery of the ignored patch.

chx’s picture

chx commented
Title: field_storage_module needs to be field_storage_default in file.crud.inc » field_storage_module needs to be field_storage_default in field.crud.inc
Status: Needs review » Reviewed & tested by the community

It's one of those absolutely trivial, small mistakes that undermine the huge efforts to make the storage engine pluggable. But it's so easy to fix. The original post lacks an explanation:

grep -n variable_get *
field.crud.inc:289:    'type' => variable_get('field_storage_default', 'field_sql_storage'),
field.crud.inc:426:  module_invoke(variable_get('field_storage_module', 'field_sql_storage'), 'field_storage_update_field', $field, $prior_field, $has_data);

the two variables need to be called the same and we opted on _default.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Good catch, litwol and chx. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

yched’s picture

yched commented

Wrong fix :-)
#693054: field_update_field() calls the wrong field storage backend