Comment cleanup of includes/database/database.inc [#672268]

Comment	File	Size	Author
#3	database-comments-cleanup-2-d7.patch	39.14 KB	Garrett Albright
	database-comments-cleanup-d7.patch	39.03 KB	Garrett Albright

Comment #1

Garrett Albright commented 2 January 2010 at 00:23

Issue tags:

+Coding standards

+tag

Log in or register to post comments

Comment #2

Crell commented 2 January 2010 at 21:37

Status:

Needs review

» Needs work

The @return statement for the docblock of DatabaseConnection::query() changes "insert id" to "insert IT". I suspect that is an error. :-)

The docblock for NoActiveTransactionException is wrong, because it's now multi-line for the first line. Class docblocks follow the same rules as function docblocks in that regard.

Same problem for db_query_range() and db_query_temporary(). The first line should not be multiline, even if that means it runs past 80 chars (IMO). And for DatabaseStatement::fetchAllAssoc(). I think that happens a few other times in here, too.

Thanks, Garrett!

Log in or register to post comments

Comment #3

Garrett Albright commented 3 January 2010 at 04:35

Status	File	Size
new	database-comments-cleanup-2-d7.patch	39.14 KB

Okay, un-multilined the first lines. I remembered hearing about that when I first started changing things, but wasn't sure if I was remembering things correctly.