Whenever we use system_settings_form and something alters that form, any alterations by default get put below the 'Save configuration' button because it has no weight at all. Why can't we just add a default weight of 100 to $form['buttons'] so we save a step for most of our module developers? For 99% of cases we want these buttons on the bottom and not in the middle of a form.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 645758-system-settings-form-button-weight-D7.patch | 753 bytes | dave reid |
| #1 | 645768-system-settings-form-button-weight-D7.patch | 966 bytes | dave reid |
Comments
Comment #1
dave reidComment #2
dave reidComment #3
dave reidRe-rolled for latest $form['actions'] array.
Comment #4
jide commentedSeems pretty straightforward :) Had this issue numerous times too.
Comment #5
dries commentedCommitted to CVS HEAD.
Comment #6
jide commentedShould not we do the same for other forms ?
Comment #7
dave reid@jide: Yes and file issues for their respective modules.
Comment #8
jide commented@Dave Reid: That would overcomplicate things don't you think ? There are plenty of them, and since #482816: Make a consistent wrapper around submit buttons addressed all submit buttons in one issue, I thought we could do the same for the weight issue.