As part of the discussion on IRC about #639738: Help File Fixup: Path module, it was decided that if we had a status report entry for Clean URLs, we could remove mention of it from path_help(). Even without that, I still think this would be a useful enhancement so when users move sites between hosts (or they break their .htaccess), they can be alerted if Clean URLs are broken.

CommentFileSizeAuthor
#1 644388_clean_url_status.patch4.56 KBdeviantintegral

Comments

deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
StatusFileSize
new 644388_clean_url_status.patch4.56 KB

Here's a patch which checks the status of clean URLs for the status report. At this point, the text for each message is a placeholder, and probably all need to be replaced.

Checking for clean URLs is also refactored into a system_check_clean_url() function. Finally, system_cron() is updated to automatically disable clean URLs if they don't work. This way, in the worst case that your server breaks the functionality, eventually your site will at least be viewable again. The last bit I'm OK with moving into a new issue, but it was trivial to implement and seems to be best committed along with any text messages for the status report.

No tests yet - lets see if I broke any existing ones first.

MichaelCole’s picture

MichaelCole commented

#1: 644388_clean_url_status.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 644388_clean_url_status.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (won't fix)

Configurable clean URLs have been removed and are always enabled now:
#1183208: Remove variable_get('clean_url') and switch to index.php/path pattern for dirty URL support