Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Comment lists should be filterable. A typical use case is the one introduced in #539110-61: TF #4: Translatable fields UI: per-language filtering.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | comment-641034-1.patch | 972 bytes | plach |
Comments
Comment #1
plachSee #539110-61: TF #4: Translatable fields UI for a detail.
Comment #2
plachIMO this issue is only an exception: we need those tags primarly beacuse in the case of comments the item list is embedded into another's entity renderable content, so it's not that easy to replace it with a view (and core can't do that), I can't think of other item lists in core with the same problems.
Comment #3
sunerr... this code just adds context, but doesn't change any behavior and doesn't add any visible functionality. Can you explain again why we need this?
Comment #4
plachIn TF4 we need this to allow to filter comment lists per language, this way different translations may appear as different nodes.
Comment #5
sunAlrighty!
Comment #6
webchickI had asked plach on IRC whether it made sense to generalize this out a bit, since it seemed odd to add such metadata to comment queries and not others. He said that comments are really the only thing, in core at least, that's tricky like this because it's inherently tied to a node, and needs to get translation data from that.
Committed to HEAD!
Comment #7
plachyay!