Describe your changes:

This patch was applied against the drupal-4.4.0-rc release pulled Mar 01 around 14:00.

This patch creates a new 'administer -> configuration' option for the cron system, allowing the Admin to enable or disable the watchdog() logging of Cron runs. By default the cron watchdog logging is enabled, as per the default behavior.

I run cron several times an hour, since I'm pulling in several RSS/XML feeds that are very active, and I want to insure I get updates in a timely manner. The cron watchdog logging isn't necessary for me, and I find I'm always hacking the cron.php file to disable it. I assume this is a feature enhancement that will be beneficial to others.

Separate your changes:

This patch modifies the cron.php and modules/system.module file to add support for the Admin configurable toggle (Enable/Disable) of the cron watchdog logging. I've created a generic "cron settings" group which the "cron watchdog logging settings" is part of. This way if there are any future enhancements/admin options made for the cron system, they can logically fall into this group.

Submitting your patch:

Patch supplied. To patch change to the base drupal directory, and do

patch -p0 -u < cron-4.4.0-rc.patch

CommentFileSizeAuthor
#7 cron_watchdog.patch900 byteshutch
#4 cron.patch1.26 KBshane
cron-4.4.0-rc.patch1.24 KBshane

Comments

TDobes’s picture

TDobes commented

The explicit links in the description you add to the admin interface will not work for sites not using clean URL's. Please modify them to use the url() function. (as your "cron documentation" link does)

Other than that, I agree that a toggle on this watchdog would be useful.

dries’s picture

dries commented

The URLs need fixing as per TDobes explanation. Marking this 'active' until the patch gets fixed. That said, I'm not sure that this is a much needed feature; in the end, we might end up having toggles for every single watchdog message ...

Anonymous’s picture

(not verified) commented

I certainly will make use of this ability on at least 6 Drupal sites.

shane’s picture

shane commented
StatusFileSize
new cron.patch1.26 KB

Attached is the new patch with the corrected URl strings using the url() function.

As usual do "patch -p0 -u < cron.patch" from the base installed Drupal directory to
apply the patch. Please let me know if there is anything else.

alexandreracine’s picture

alexandreracine commented
Version: x.y.z » 4.5.0

This was for a 4.4 drupal.

I guess it is now implemented?

Closing.

Uwe Hermann’s picture

Uwe Hermann commented
Version: 4.5.0 » 6.x-dev

Nope, I don't think it's implemented. Moving to 6.x-dev.

hutch’s picture

hutch commented
Version: 6.x-dev » 4.7.5
Assigned: Unassigned » hutch
Category: task » feature
StatusFileSize
new cron_watchdog.patch900 bytes

Here is an updated version on Drupal 4.7.5
It patches system.module,v 1.320.2.19 and cron.php,v 1.34
It creates a checkbox rather than radios, and has a description added.
It should not appear if cron is not running (not tested)
The default is Enabled

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Version: 4.7.5 » 7.x-dev
Status: Active » Needs work
hutch’s picture

hutch commented

This feature is not relevant to D6 and D7 as the filtering system in reports already allows such filtering by other means, a much more elegant solution IMHO.
For D5 I have a patch that allows the choice to be inverted, I don't recall where it was posted but if anyone needs it just ask.

brianV’s picture

brianV commented
Version: 7.x-dev » 5.x-dev
Status: Needs work » Closed (won't fix)

hutch is correct that this issue is irrelevant to D6 and D7. Furthermore, we aren't adding new features to 5.X.

Because of the above, I am closing this issue.