field_info_bundles() return format changed after #470242: Namespacing for bundle names : array first keyed by obj_type then by bundle
The call in _field_info_collate_fields() did not fully reflect that.

At least a confusing variable name ($bundle contained an object type)
+ we previously initialized empty arrays for each bundle, the current code only initializes at the 'object type' level. No biggie, but might avoid some if (isset()) down the road.

RTBC after bot comes back green.

CommentFileSizeAuthor
field_info_smallfix.patch1.29 KByched

Comments

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, so marking fixed.

But are there some of said isset() calls we could clean up as well?

Also, great to see you back, yched! :D

yched’s picture

yched commented

Thx Angie.

"But are there some of said isset() calls we could clean up as well?"
Actually, not in our current code, but this might be the case for other (later or contrib) consumers of field_info_instances().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.