file_build_uri() uses the variable name file_scheme_default — it should have been file_default_scheme instead. The former is not used anywhere else in core.

CommentFileSizeAuthor
#3 file_build_uri-2.patch5.8 KBc960657
file_build_uri-1.patch966 bytesc960657

Comments

dries’s picture

dries commented
Issue tags: +Needs tests

It looks like we have a hole in our test coverage here so marking 'code needs tests'.

jim0203’s picture

jim0203 commented

In any event, this reviews fine. file_scheme_default is not a valid variable; the one that is required here is file_default_scheme. Pass.

c960657’s picture

c960657 commented
StatusFileSize
new file_build_uri-2.patch5.8 KB

Added some tests.

dries’s picture

dries commented
Status: Needs review » Fixed

Thanks for writing some extra tests! Committed to CVS HEAD. :)

Status: Fixed » Closed (fixed)
Issue tags: -Needs tests

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs tests

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.