Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Oct 2009 at 21:14 UTC
Updated:
22 Oct 2009 at 14:34 UTC
the arguments to drupal_goto() changed, but form_state_redirect() is still trying to call it with the old argument structure when $form_state['redirect'] is an array.
attached patch seems to fix the issue
| Comment | File | Size | Author |
|---|---|---|---|
| fix_form_redirects.patch | 794 bytes | hunmonk |
Comments
Comment #2
hunmonk commentedok, after further investigation, the core code is correct, it's the upgrade documentation that's busted ;)
a search of http://drupal.org/update/modules/6/7 for both 'form' and 'redirect' doesn't yield any information about the change to the format of $form_state['redirect']. the upgrade doc should probably go something like this:
the format of $form_state['redirect'] has changed. it is now a numerically indexed array, the first element is the path, and the second element is an array of options that url() can take.
example:
6.x
7.x
Comment #3
jhodgdonAny idea which issue/patch changed that behavior? The reason I am asking is that normally when we add stuff to the module upgrade guide, we link to the issue, and also if anything else changed in that issue's patch it gets documented there.
Comment #4
stborchertdrupal_gotohas been changed in #216098: drupal_goto() does not follow same parameters as url()Comment #5
jhodgdonIt looks like that issue is indeed where this was changed, and that issue is still open and marked "needs documentation" because it needs to be documented in the update guide.
So this issue is a duplicate.