The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Running node revision test on my box I have the following fatal error:
Fatal error: Unsupported operand types in D:\psegno\sviluppo\drupal-7.sviluppo\modules\simpletest\drupal_web_test_case.php on line 734
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | node_revision_test-606460-2.patch | 815 bytes | peximo |
Comments
Comment #1
peximo commentedIn NodeRevisionsTestCase:setUp() first is created a node then got the settings from this node and create a new one (revision).
The test fail because in DrupalTestCase:drupalCreateNode() we control if $settings->language is setted but not if is empty.
The patch control if $settings->language is empty and solve this problem.
Comment #2
peximo commentedComment #3
dave reidThe code in NodeRevisionsTestCase:setUp() doesn't set a language value for the nodes passed into drupalCreateNode() so this should work just fine. Also, we would have seen this failure from the test bot. Double check all your code is the most up-to-date code.
Comment #4
peximo commentedI have the latest checkout, it is a fatal error so the test bot migth not report it. Just run the node revision test on your box and you see this.
Comment #5
plachI confirmed this behavior on my box, fresh head checkout and fresh install.
Comment #6
dave reidActually the bot should be reporting fatal errors. That's really odd...
Comment #7
dave reidTested and that's the best fix for this.
Comment #8
webchickThanks. I asked Dave to file a follow-up issue in the PIFR queue about the fact that it's not catching this.
Committed to HEAD!
Comment #9
dave reid#606522: Testbot is missing fatal errors