patch -p0 < die__taxonomy_term_select_die_01.patch and you give life to a nice and fluffy hairball kitten.

CommentFileSizeAuthor
#5 die__taxonomy_term_select_die_02.patch6.5 KBxano
die__taxonomy_term_select_die_01.patch5.38 KBxano

Comments

Anonymous’s picture

Anonymous (not verified) commented

This isn't what I expected to see. I thought we were removing taxonomy_form! I would love to see _taxonomy_term_select go as well, but... here? now?

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -D7 API clean-up

I agree with bangpound

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Why is this no API cleanup? This patch cleans up a lot of unused and unnecessary code. It's a partial consequence of the Taxonomy field API integration.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new die__taxonomy_term_select_die_02.patch6.5 KB

All patches that failed on t.d.o now pass locally.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This is the biggest, gaping scab left in taxonomy.module after the fields patch landed. Let's flick it off.

Anonymous’s picture

Anonymous (not verified) commented

This makes taxonomy.module a less misfitting member of the Drupal module family. RTBC++

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Looks good to me. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned