The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.I noticed the following. When you start editing existing role and you enter empty string, the result is not what is expected. Insted of geeting the error and edit form, you get an error and add form.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | empty_role_error_2_47.patch | 1.87 KB | edmund.kwok |
| #8 | empty_role_error_47.patch | 2.74 KB | edmund.kwok |
| #4 | empty_role_error_2.patch | 1.65 KB | edmund.kwok |
| #2 | empty_role_error.patch | 1.38 KB | edmund.kwok |
Comments
Comment #1
Uwe Hermann commentedConfirmed in CVS HEAD. I'll set this to critical, feel free to lower the severity if you don't think it's critical.
Comment #2
edmund.kwok commentedPatch checks to display role edit form in a seperate if...else statement rather than at the end of the operation check.
Comment #3
dries commentedAlso, the "Role name"-textfield is required, and should have the "'#required' => TRUE" attribute. Maybe that can be fixed too.
Good job, guys.
Comment #4
edmund.kwok commentedAdded the #required attribute to the role name textfield as suggested by Dries.
Comment #5
edmund.kwok commentedAdded the #required attribute to the role name textfield as suggested by Dries.
Comment #6
drummCommitted to HEAD.
While testing this is noticed that there is no protection against duplicate role names. I assume this is a preexisting problem and should be covered by a separate patch.
Comment #7
edmund.kwok commentedDuplicate role name problem is addressed in http://drupal.org/node/41293.
Comment #8
edmund.kwok commentedBackported to 4.7 with a slight addition to 'theme_user_admin_new_role'.
Comment #9
edmund.kwok commentedUpdated patch for 4.7. This time no change in 'theme_user_admin_new_role'.
Comment #10
gerhard killesreiter commentedbackported
Comment #11
(not verified) commented