All of the items of hte search admin settings form are in fieldsets except the Module List, which makes the form look odd. The rationale is obviously not that fieldsets only go around multiple items, because there are two other elements of the form that contain a single item in a fieldset.
Patch will add a fieldset wrapper around the module settings.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | Picture 3.png | 94.76 KB | agentrickard |
| #8 | 566678-search-form.patch | 4.29 KB | agentrickard |
| #2 | before.jpeg | 7.59 KB | dawehner |
| #2 | after.jpeg | 9.83 KB | dawehner |
| #1 | 566678-search.patch | 1.5 KB | agentrickard |
Comments
Comment #1
agentrickardThe patch.
Comment #2
dawehnerI needed some time to see the changes, so i post them here.
It definitive looks much more consistent.
Comment #3
yoroy commentedOnly posting a bigger 'before' to demonstrate it's weird looking indeed:
Comment #4
agentrickardIMO: We need UI guidleines for fieldsets. I don't understand why single form elements get fieldsets, but since they do on this page, then everything needs to do in a fieldset.
Comment #5
agentrickardAccidental cross-post changed status. Oops.
Comment #6
yoroy commentedThe guideline is to *not* frame the main interaction of a form into a fieldset and group secondary, related functionality into fieldsets below.
for example: admin/config/content/formats/1
I'm not familiar enough with these settings to know if these are in the right order, from most important to less? I guess the first one, 'indexing status' is probably the most used one indeed?
Looking at the bigger picture:
- remove the fieldset around 'indexing status'
- combine the 'throttle' and 'settings' fieldsets into one 'Indexing' fieldset
- add a fieldset around the 'active modules'
- leave 'content ranking' as is.
up for it?
Comment #7
webchickI agree it'd be nice to fix this all in one go, rather than simply adding more visual noise for the sake of consistency.
Comment #8
agentrickardHere's a patch that follows the guide from #6. One problem, we now need spacing between the index button (at the top) and the first fieldset. (Maybe this is why the first element was in a fieldset after all.)
Best way to add that space?
Comment #9
agentrickardAnd a pic, for the visually-minded. This is FireFox 3 on a Mac.
Comment #10
yoroy commentedSeven's style.css has styling for input.form-submit at line 552. Looking at the original design mockups by Mark Boulton, and found we need some margins there anyway, for the submit buttons on the bottom of pages as well:
margin: 16px 12px 12px 0;
should do the trick.
Otherwise, this patch is ok. thanks.
Comment #11
jhodgdonBump. Anyone want to update this, and is it still an issue?
Comment #12
jhodgdonThis has apparently been fixed in Drupal 7. It doesn't apply to Drupal 6 and before, since they didn't have the ability to turn off individual search modules.