Closed (fixed)
Project:
Drupal core
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
3 Feb 2004 at 18:04 UTC
Updated:
22 Feb 2004 at 18:20 UTC
Jump to comment: Most recent file
TADA! Here is patch to fix most of the t() isssues in Drupal core.
- Add the 'admin/system/modules#name' help section back in to provide the
translated name of the module (used at various places)
- Modified the _perm() hook to return an associative array with the permissions
and their translated counterpart (since user module would translate the
permission names anyway later on)
- Modified the locale.module code to contain the date strings literally,
making them available for .pot generation
- Fix format_date() to only t() on components which are strings
- Some other small bugs in tablesort.inc and archive.module
A highly recommended patch to make Drupal work with extractor.php.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Drupal-fix-t-issues.patch | 2.92 KB | gábor hojtsy |
| #4 | Drupal-fix-pot-errors-big_2.patch | 38.45 KB | gábor hojtsy |
| #3 | Drupal-fix-pot-errors-big_0.patch | 38.45 KB | gábor hojtsy |
| Drupal-fix-pot-errors-big.patch | 39.65 KB | gábor hojtsy |
Comments
Comment #1
gábor hojtsyComment #2
dries commentedI already committed a small subset of this patch.
Comment #3
gábor hojtsyYes, the few patched lines to tablesort.inc... Here is an uptodate patch then against current CVS.
Comment #4
gábor hojtsyUps, found a small typo, which needed correction in the patch.
Comment #5
gábor hojtsySince on IRC, I had been told that I'd better put the special case codes into extractor.php, I have put the date and format_interval() handling code to extractor.php (also extended the script to extract perm hook strings).
That means that from my big patch only the fixing in archive.module needs to be committed. I have also included a patch against locale.module that removes the admin init function that adds the initial date strings (since this is in the extractor.php code). That means that people using the regular translation methods will not see all the strings right away, but people use the .po way will see them (so far this was the other way round).
Comment #6
gábor hojtsyFixed in CVS, patch committed.
Comment #7
(not verified) commented