Remove hook_filter_tips in favor of a 'tips callback' provided by a info hooks for filters.

Related issues:
#546336: hook_filter_info(): Remove $op from hook_filter()
#546350: Remove hardcoded numeric deltas from hook_filter_info()

CommentFileSizeAuthor
#2 remove-hook_filter_tips.patch23.6 KBdropcube

Comments

dropcube’s picture

dropcube commented
Priority: Normal » Critical
Status: Postponed » Active

I am marking this critical, as this is an API change we should get in before the code freeze.

dropcube’s picture

dropcube commented
Status: Active » Needs review
StatusFileSize
new remove-hook_filter_tips.patch23.6 KB

This patch removes hook_filter_tips implementations from core and includes the filter tips in callback functions, declared in hook_filter_info() with "tips callback" key.

moshe weitzman’s picture

moshe weitzman commented
Priority: Critical » Normal

Please justify your patch and your priority. "becuase we are near freeze" is not a justifcation.

dropcube’s picture

dropcube commented

@moshe: This is a follow up of #546336: hook_filter_info(): Remove $op from hook_filter() (already in core), which introduces a registry-style info hook for filters. With 'tips callback', we do not need hook_filter_tips any more. So, as this is an API change, I think it's critical to get some of this in before the freeze.

dropcube’s picture

dropcube commented
Priority: Normal » Critical
dries’s picture

dries commented
Priority: Critical » Normal
Status: Needs review » Needs work

This is a required follow-up of the filter refactoring. Committed!

Marking 'needs work' because we need to update the upgrade instructions in the handbook. Mark 'fixed' after the documentation is in place.

Thanks dropcube.

moshe weitzman’s picture

moshe weitzman commented

In the future, please use render() arrays arrays instead of strings. This delays theming until after the page is fully built. As written here, the 'Character Description' table and all the rest is baked in.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Needs documentation

Tagging.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

The module upgrade guide for this definitely needs some work, but I think it is more appropriately discussed on #546336: hook_filter_info(): Remove $op from hook_filter(), because changes to doc from that update need to be made before this one can even be addressed. So I'll add a comment there.

dropcube’s picture

dropcube commented
Status: Needs work » Fixed
Issue tags: -Needs documentation

Added upgrade instructions: hook_filter() replaced by hook_filter_info(), and removed hook_filter_tips()

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.