Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Remove hook_filter_tips in favor of a 'tips callback' provided by a info hooks for filters.
Related issues:
#546336: hook_filter_info(): Remove $op from hook_filter()
#546350: Remove hardcoded numeric deltas from hook_filter_info()
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | remove-hook_filter_tips.patch | 23.6 KB | dropcube |
Comments
Comment #1
dropcube CreditAttribution: dropcube commentedI am marking this critical, as this is an API change we should get in before the code freeze.
Comment #2
dropcube CreditAttribution: dropcube commentedThis patch removes
hook_filter_tipsimplementations from core and includes the filter tips in callback functions, declared inhook_filter_info()with"tips callback"key.Comment #3
moshe weitzman CreditAttribution: moshe weitzman commentedPlease justify your patch and your priority. "becuase we are near freeze" is not a justifcation.
Comment #4
dropcube CreditAttribution: dropcube commented@moshe: This is a follow up of #546336: hook_filter_info(): Remove $op from hook_filter() (already in core), which introduces a registry-style info hook for filters. With
'tips callback', we do not needhook_filter_tipsany more. So, as this is an API change, I think it's critical to get some of this in before the freeze.Comment #5
dropcube CreditAttribution: dropcube commentedComment #6
Dries CreditAttribution: Dries commentedThis is a required follow-up of the filter refactoring. Committed!
Marking 'needs work' because we need to update the upgrade instructions in the handbook. Mark 'fixed' after the documentation is in place.
Thanks dropcube.
Comment #7
moshe weitzman CreditAttribution: moshe weitzman commentedIn the future, please use render() arrays arrays instead of strings. This delays theming until after the page is fully built. As written here, the 'Character Description' table and all the rest is baked in.
Comment #8
webchickTagging.
Comment #9
jhodgdonThe module upgrade guide for this definitely needs some work, but I think it is more appropriately discussed on #546336: hook_filter_info(): Remove $op from hook_filter(), because changes to doc from that update need to be made before this one can even be addressed. So I'll add a comment there.
Comment #10
dropcube CreditAttribution: dropcube commentedAdded upgrade instructions: hook_filter() replaced by hook_filter_info(), and removed hook_filter_tips()