Add presave hook to comments

+function hook_comment_presave(&$comment) {

The & is not necessary, in fact, it results in a warning in PHP 5.3

Makes perfect sense. Consistency++. And useful too.

+++ modules/comment/comment.module	2009-08-11 08:40:03.000000000 -0400
@@ -1235,6 +1235,8 @@ function comment_save($comment) {
+  // Allow modules to alter the comment before saving.
+  module_invoke_all('comment_presave', $comment);
   field_attach_presave('comment', $comment);
 

Actually, I think it makes more sense to run this op after the fields have been attached. This is consistent with where our alter hooks are elsewhere.

+++ modules/comment/comment.api.php	2009-08-11 08:40:32.000000000 -0400
@@ -12,6 +12,18 @@
+  // Change here the comment object before is saved...

Not quite proper grammar. Probably just:

// Change the comment object before it is saved.

However, it'd be nice to have an actual use case here. What's your motivation behind rolling this patch? What specifically are you trying to do in op presave? Can you make it a 2-3 line example here?

This review is powered by Dreditor.

"run this op after the fields have been attached"
+1. Node module runs hook_node_* after field_attach_*.
Also, those two lines shouldn't be grouped under the same "// Allow modules to alter the comment before saving." comment.

The example hook_comment_presave() should have some example code in it that shows how one might alter the $comment object and then return it. See hook_node_presave() as an example.

Otherwise, +1, and the rest of the patch looks good.

Thanks. RTBC.

Committed to HEAD. Thanks, Claudiu! :)

Marking "needs work" because this needs to be documented in the 6 to 7 upgrade guide. Once this is done, please mark back to "fixed."

I think the example hook_comment_presave() code is still a little off. This line,

+function hook_comment_presave($comment) {

Should show that the $comment variable needs to be passed by reference, &$comment, if you don't pass by reference any action taken on the $comment object inside your presave hook will be lost.

eojthebrave: Actually, no. Objects no longer need the & to be passed by reference as of PHP 5 and this will in fact create a warning in PHP 5.3.

@webchick, good to know. Thanks.

You should do the opposite and add it to the end :)