When an exception occurs directly inside the PDO class, the backtracing logic of the exception handler fails because the PDO classes are not explicitly listed there.

CommentFileSizeAuthor
#3 543594-exceptions-in-pdo.patch1.07 KBdamien tournoud
#2 543594-exceptions-in-pdo.patch1.11 KBdamien tournoud
#1 543594-exceptions-in-pdo.patch1.11 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 543594-exceptions-in-pdo.patch1.11 KB
damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 543594-exceptions-in-pdo.patch1.11 KB

Angie noted that checking for PDOStatement is now redundant.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 543594-exceptions-in-pdo.patch1.07 KB

Uploaded the wrong patch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

Damn, that's one ugly line of code. But the new check catches a wider range of PDO-related stuff, so seems correct.

Committed to HEAD. This should help us get SQLite tests passing. Woot! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.