PHP notice on admin/build/modules

We dug a bit deeper in IRC about this, and it turns out this only occurs the first time the page is loaded that a new module is in there it doesn't know about yet.

As best we can tell, this happens because http://api.drupal.org/api/function/system_get_files_database/7 is querying the database, and there's no record of the module there yet.

So while sun's patch will mask the issue, it seems like there might be something deeper...

... but we also want to add a static of some sort to system_get_module_data() in order not to traverse the whole file tree twice in search of modules.

@4

Actually, we do it 3 times already :) (twice with system_get_module_data() and the registry does it directly to save update queries that we don't execute anymore).

I tried to implement the static cache in #147000-30: Rewrite module_rebuild_cache() and system_theme_data() already, but failed because simpletest had issues with that and I didn't wanted to delay that issue.

I changed the registry_rebuild() function in #429132: Remove unecessary module_rebuild_cache() call from _registry_rebuild(), now that we optimized system_get_module_data() (And will hopefully further improve it), we can revert that, I think. Not that you can also remove the ini file parsing stuff then.

Adding a static cache and getting the tests working seems to be hard, so I just reverted my patch in _registry_rebuild() for now.

That was the wrong patch...

And now the correct status...

Looks clean and fixes issue.

I like the resulting code much better. I think according to Berdir in #7 that the performance hit isn't as great anymore, but I'm sure catch will inform us if that's not the case. ;)

Committed to HEAD!