patch.

CommentFileSizeAuthor
#2 panels.patch2.39 KBcatch
panels.patch2.06 KBcatch

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Needs work

To clarify for those not in #drupal. ;)

We enabled search module by default in #503982: Enable search module by default and it caused this test to fail. The reason is because the test makes some hard-coded assumptions about what sections should and should not appear here.

However, if we're going to remove this assertion, we should also remove the $extras variable, since there's no reason to calculate it if we never check it.

But looking at this closer, I'm not sure this is exactly the right fix. That whole test could do with some general sanity checking.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new panels.patch2.39 KB

Re-roll to remove the $extras variable. While I agree this could do with fixing things up, it's currently holding up other patches which are more important.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

Ok. Committed this to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.