SimpleTest has two variables which can be quite handy, but both of which are not visible in any way other then by reading the code.

This patch creates a settings page for the two variables and is in preparation for the verbose mode setting to be provided by #500280: Provide a verbose mode for SimpleTest.

CommentFileSizeAuthor
#12 500292-simpletest-settings.patch4.17 KBboombatower
#10 500292-simpletest-settings.patch4.25 KBboombatower
#1 500292-simpletest-settings.patch2.45 KBboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 500292-simpletest-settings.patch2.45 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review

Test slave crapped.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

Very handy.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Reviewed & tested by the community
dries’s picture

dries commented

- If we're going to accept auth information we should have a username and password field IMO.

- The form descriptions are not really helpful. They don't tell me why authentication is useful, or when it should be configured. They don't tell me why I might want to clean after each test run. I think we need to make those settings more accessible for non SimpleTest experts -- or keep them hidden.

- Shouldn't this live under Site configuration?

boombatower’s picture

boombatower commented

I purely matched SimpleTest variable that is a single field for username/password, I'll split it up on form.

Will add descriptions.

I wasn't sure about it living under site configuration. SimpleTest is a development tool and doesn't effect the overall site so it seemed odd to place it in site configuration. Most development tools have their own special settings and such and this seemed like a clean pattern to keep them out of site configuration.

Since I am starting something new I definitely want opinions...

I'll try and get new patch shortly.

boombatower’s picture

boombatower commented

This should do the trick.

Please let the hook_uninstall() variable removal be cleaned up in separate issue: #500270: SimpleTest hook_uninstall() does not delete the correct variables

boombatower’s picture

boombatower commented
StatusFileSize
new 500292-simpletest-settings.patch4.25 KB
dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

- Can you put the help text on one line for consistency?

- Where can people fine the [result_id]? The documentation is not telling me that.

- Can we reduce 'simpletest_httpauth_credentials_username' to 'simpletest_username'? Ditto for password.

Otherwise looks good.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 500292-simpletest-settings.patch4.17 KB

Summary of what this patch does:

  • Splits the variable simpletest_httpauth_credentials into simpletest_username and simpletest_password.
  • Provides a settings page for the httpauth variables and the simpletest_clear_results variable.

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
dries’s picture

dries commented
Status: Needs review » Fixed

OK, the latest changes look good. The location of the settings page is OK for now, but could be revisited as part of the new IA. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.