Inspired from: #395472: Plugin Manager in Core: Part 1 (backend)

The victory condition for this is:

Users should be able to use SSH, FTP and FTP with stream wrappers to perform the following operations:

->copyDirectory(source, remote_destination)
->copyFile(source, remote_file)
->mkdir(remote_dir)
->rmdir(remote_dir)
->rmFile(remote_dir)

Also lumped in here for no good reason other than history is a new function in system to allow for downloading files via HTTP and storing them in the files directory.

CommentFileSizeAuthor
#1 filetransfer_core-499628-1.patch12.58 KBJacobSingh

Comments

JacobSingh’s picture

JacobSingh commented
Status: Active » Needs review
StatusFileSize
new filetransfer_core-499628-1.patch12.58 KB

This is chx's patch from: http://drupal.org/comment/reply/395472#comment-1732364

with a few of my changes to the function is system.module

JacobSingh’s picture

JacobSingh commented
Status: Needs review » Needs work

At least the SSH Filetransfer class is broken:

function connect() {
    $this->connection = @ssh2_connect($setings['hostname'], $this->port);
    if (!$this->connection) {
      throw new FileTransferException('SSH Connection failed.');
    }
    if (!@ssh2_auth_password($this->connection, $this->username, $this->password)) {
      throw new FileTransferException('The supplied username/password combination was not accepted.');
    }
  }

Where is $setings coming from?

Even if it was $settings, it still wouldn't work.

JacobSingh’s picture

JacobSingh commented

@Dries: Are you going to roll back the patch with the bugs in it or should chx/I re-roll based on what is in there?

drewish’s picture

drewish commented

subscribe... where does this actually sit?

JacobSingh’s picture

JacobSingh commented
Status: Needs work » Closed (duplicate)

I tried to fork off the previous issue: #395472: Plugin Manager in Core: Part 1 (backend) to try and get more clarity, but it never moved.

-J