1. Visit admin/build/block/configure/system/powered-by
2. Wait a few seconds.
3. Watch as the browser redirects to admin/settings/clean-urls
4. ???
5. WTF!

:)

CommentFileSizeAuthor
#2 system-clean-url-redirect-496922-1.patch838 bytescburschka
#1 drupal.powered-by-js-gurus.patch831 bytessun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new drupal.powered-by-js-gurus.patch831 bytes
cburschka’s picture

cburschka
they
commented
Component: block.module » system.module
StatusFileSize
new system-clean-url-redirect-496922-1.patch838 bytes

Simple, really. The system.js script naively registers a behavior that will always run, assuming for some reason it will only be loaded on the clean-url page.

This fix adds a check that will not run the clean-url test if the #edit-clean-url checkbox does not exist on the page (while still aborting if it is there, but marked with .install, as before).

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

Yikes. Committed to HEAD. Thanks for tracking that down.

c960657’s picture

c960657 commented

This fix adds a check that will not run the clean-url test if the #edit-clean-url checkbox does not exist on the page (while still aborting if it is there, but marked with .install, as before).

If the #edit-clean-url checkbox is displayed, the there is no reason to run the test, right? If I understand this correctly, the test should only run if the #edit-clean-url-test button is displayed. If the button is not displayed, system.js is not included on that page.

So I think the fix is wrong. This is actually a duplicate of #479604: Drupal.behaviors.cleanURLsSettingsCheck() in system.js redirects to clean urls settings page incorrectly., so I suggest that the discussion continues in that issue.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

The patched fixed the problem, but it's not very clean. #479604: Drupal.behaviors.cleanURLsSettingsCheck() in system.js redirects to clean urls settings page incorrectly. will deal with cleaning up system.js and finetune the fix.

// Okay, next time I gotta refresh issues before commenting :P

c960657’s picture

c960657 commented

It fixed the problem, yes, but AFAICT it broke the only place where the JS check was actually supposed to be used.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Should I roll this back, or should we reconvene in the other issue?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

The other issue already contains a patch that should fix all of this properly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.